fix device mismatch issue for HiDreamTransformerTests#13766
Merged
Conversation
Signed-off-by: Liu, Kaixuan <[email protected]>
Signed-off-by: Liu, Kaixuan <[email protected]>
DN6
approved these changes
May 19, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
The failed lora tests should have nothing to do with this PR. |
Collaborator
|
@kaixuanliu thanks a ton for the fix! |
DN6
pushed a commit
that referenced
this pull request
Jul 1, 2026
* fix device mismatch issue for HiDreamTransformerTests Signed-off-by: Liu, Kaixuan <[email protected]> * refine code Signed-off-by: Liu, Kaixuan <[email protected]> --------- Signed-off-by: Liu, Kaixuan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix bug in test case:
tests/models/transformers/test_models_transformer_hidream.py::HiDreamTransformerTests::test_sharded_checkpoints_device_map@sayakpaul @yiyixuxu @DN6 pls help review, thx!