Fix typos, improve, update at main-page files and .github files#5588
Merged
Conversation
… to Diffusers' forum
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
|
cc'ing: @stevhliu as well. |
stevhliu
reviewed
Oct 31, 2023
stevhliu
left a comment
Member
There was a problem hiding this comment.
Nice, thanks for reviewing even the setup files for typos 🙂
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
stevhliu
reviewed
Nov 1, 2023
Co-authored-by: Steven Liu <[email protected]>
Contributor
|
Feel free to merge once you're happy with the PR @stevhliu |
stevhliu
reviewed
Nov 2, 2023
stevhliu
left a comment
Member
There was a problem hiding this comment.
Just a few more changes and we should be good to merge :)
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Member
|
Feel free to ping me for another review after you've addressed all the feedback @StandardAI! 🤗 |
Contributor
Author
|
@stevhliu |
Co-authored-by: Steven Liu <[email protected]>
stevhliu
approved these changes
Nov 14, 2023
stevhliu
left a comment
Member
There was a problem hiding this comment.
Thanks for iterating and improving this PR!
Contributor
Author
Thanks for your feedback! |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…ingface#5588) * Update keywords; remove version cuz it changes constantly? * Update if necessary * Fix typos and links * version_range_max from PyTorch's setup.py; fix typos; 1 checklist is enough? * Fix a typo * Fix typos * There is already a Blank issue link at the bottom of the page; direct to Diffusers' forum * Add 🌐 Translating a New Language? page * Update .github/ISSUE_TEMPLATE/translate.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md * Update PHILOSOPHY.md * Update CONTRIBUTING.md Co-authored-by: Steven Liu <[email protected]> * Update CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update README.md Co-authored-by: Steven Liu <[email protected]> * Add X account link * Update setup.py * Update CITATION.cff --------- Co-authored-by: Steven Liu <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…ingface#5588) * Update keywords; remove version cuz it changes constantly? * Update if necessary * Fix typos and links * version_range_max from PyTorch's setup.py; fix typos; 1 checklist is enough? * Fix a typo * Fix typos * There is already a Blank issue link at the bottom of the page; direct to Diffusers' forum * Add 🌐 Translating a New Language? page * Update .github/ISSUE_TEMPLATE/translate.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md * Update PHILOSOPHY.md * Update CONTRIBUTING.md Co-authored-by: Steven Liu <[email protected]> * Update CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update README.md Co-authored-by: Steven Liu <[email protected]> * Add X account link * Update setup.py * Update CITATION.cff --------- Co-authored-by: Steven Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hi! Thank you for this awesome library!
I am new to open source. Firstly, I am reading the documentation. Secondly, I will read the codebase. Thirdly, I plan to make documentation and code contributions.
I would be grateful for your feedback. @stevhliu @yiyixuxu @patrickvonplaten
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.