Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Optional type annotation #36841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 26, 2025
Merged

Fix Optional type annotation #36841

merged 5 commits into from
Mar 26, 2025

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 20, 2025 •
edited
Loading

What does this PR do?

Add Optional to some annotations for None default values.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions GitHub Actions
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@github-actions github-actions bot marked this pull request as draft March 20, 2025 01:20
@cyyever cyyever changed the title Fix annotation Fix incorrect type annotation Mar 20, 2025
@cyyever cyyever marked this pull request as ready for review March 20, 2025 01:31
@github-actions github-actions bot requested a review from gante March 20, 2025 01:31
@cyyever cyyever marked this pull request as draft March 20, 2025 02:14
@cyyever cyyever force-pushed the fix_annotation branch 3 times, most recently from b791949 to 3ef9724 Compare March 20, 2025 02:27
@cyyever cyyever changed the title Fix incorrect type annotation Fix Optional type annotation Mar 20, 2025
@cyyever cyyever marked this pull request as ready for review March 20, 2025 02:30
gante
gante reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening the PR! Looks mostly good to me, a few nits should be corrected :)

@cyyever cyyever force-pushed the fix_annotation branch 2 times, most recently from 4ef66ee to 53ec065 Compare March 20, 2025 13:36
@cyyever cyyever requested a review from gante March 20, 2025 13:37
@cyyever cyyever force-pushed the fix_annotation branch 2 times, most recently from 1344c41 to 61d9569 Compare March 20, 2025 14:22
gante
gante approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for iterating 🤗

@gante gante merged commit 8084b26 into huggingface:main Mar 26, 2025
21 checks passed
@cyyever cyyever deleted the fix_annotation branch March 26, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gante gante gante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyyever @gante