Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Compressed tensors to_dict_diff #36922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2025
Merged

Fix Compressed tensors to_dict_diff #36922

merged 3 commits into from
Mar 24, 2025

Conversation

MekkCyber
Copy link
Contributor

What does this PR do?

When creating the dict config, checks if the key exists in the defaut config before trying to access its value.
It was causing the error :

File "./transformers/src/transformers/utils/quantization_config.py", line 1364, in to_diff_dict
    if value != default_config_dict[key]:
                ~~~~~~~~~~~~~~~~~~~^^^^^
KeyError: 'config_groups'

@MekkCyber MekkCyber requested a review from SunMarc March 24, 2025 10:53
@github-actions github-actions bot marked this pull request as draft March 24, 2025 10:53
@github-actions GitHub Actions
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@MekkCyber MekkCyber marked this pull request as ready for review March 24, 2025 11:02
SunMarc
SunMarc approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx !

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@MekkCyber MekkCyber merged commit 9e125d9 into main Mar 24, 2025
24 checks passed
@MekkCyber MekkCyber deleted the fix_dict_compressed branch March 24, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunMarc SunMarc SunMarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MekkCyber @HuggingFaceDocBuilderDev @SunMarc