-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Updated docker files to use uv
for installing packages
#36957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Makes a lot of sense.
I have to trigger a build for the images to make sure it works before I merge.
Hi @Sai-Suraj-27 Could you check the error logs in this run: https://github.com/huggingface/transformers/actions/runs/14060656795/job/39370346086 Maybe it's as simple as using
|
Hi, Looks like, |
ok thank you. I will try later today. |
There is remaining one failing job https://github.com/huggingface/transformers/actions/runs/14063433382/job/39379784581 if you could take a look 🙏 |
Yes, I think this is actually because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the iteration.
Since this PR only add uv
before pip
and the images are successfully built, I will merge!
I see that we are not using uv anywhere in the Dockerfiles for gpu tasks. Is there any particular reason for this? |
No particular reason :-) It is built in a daily basis, and during the CI run time, we rarely install new stuff, So using But open to such changes if you want to give it a try. You might first focus on |
…#37000) fix Co-authored-by: ydshieh <[email protected]>
What does this PR do?
In many Dockerfiles
uv
is installed but still it is not used for installing packages at some places. I think usinguv
at all these places will increase the speed of respective Docker image builds by a considerable amount.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ydshieh @ArthurZucker