Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add ruff target-version #36971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Add ruff target-version #36971

merged 1 commit into from
Mar 25, 2025

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Mar 25, 2025

Target ruff to py3.9

@github-actions github-actions bot marked this pull request as draft March 25, 2025 16:27
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers.

@cyyever cyyever marked this pull request as ready for review March 25, 2025 16:28
@Rocketknight1
Copy link
Member

cc @ydshieh since I think this might affect the CI as well!

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

This looks fine as it makes sure the proposed changes are compatible with a specific python version (that we want to support).

Not affecting CI IMO, so merge it.

@ydshieh ydshieh merged commit ba53127 into huggingface:main Mar 25, 2025
9 checks passed
@cyyever cyyever deleted the ruff_version branch March 26, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants