Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update #36972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

update #36972

merged 2 commits into from
Mar 25, 2025

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Mar 25, 2025

What does this PR do?

The check_code_quality job had ruff format tests src utils --check but we need to add examples too!

@ydshieh ydshieh requested a review from stevhliu March 25, 2025 16:56
@github-actions github-actions bot marked this pull request as draft March 25, 2025 16:56
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers.

@ydshieh ydshieh requested a review from SunMarc March 25, 2025 16:56
@ydshieh ydshieh marked this pull request as ready for review March 25, 2025 16:56
@@ -154,7 +154,7 @@ jobs:
path: ~/transformers/installed.txt
- run: python -c "from transformers import *" || (echo '🚨 import failed, this means you introduced unprotected imports! 🚨'; exit 1)
- run: ruff check examples tests src utils
- run: ruff format tests src utils --check
- run: ruff format examples tests src utils --check
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we won't have such situation again in the future

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! 🤗

@ydshieh ydshieh merged commit 121830a into main Mar 25, 2025
13 checks passed
@ydshieh ydshieh deleted the update_examples branch March 25, 2025 17:15
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants