Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix llama4 training #37319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

fix llama4 training #37319

merged 1 commit into from
Apr 7, 2025

Conversation

hiyouga
Copy link
Contributor

@hiyouga hiyouga commented Apr 6, 2025 •
edited
Loading

What does this PR do?

Fix some issues during Llama 4 training using transformers.

image

Reproduce: hiyouga/LLaMA-Factory#7611

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker

@github-actions github-actions bot marked this pull request as draft April 6, 2025 05:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2025

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@hiyouga hiyouga marked this pull request as ready for review April 6, 2025 05:50
ArthurZucker
ArthurZucker approved these changes Apr 6, 2025
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@winglian winglian mentioned this pull request Apr 7, 2025
Merged
5 tasks
@ArthurZucker ArthurZucker merged commit debfe90 into huggingface:main Apr 7, 2025
7 checks passed
vasqu pushed a commit to vasqu/transformers that referenced this pull request Apr 7, 2025
@hiyouga @vasqu
fix llama4 training (huggingface#37319)
388ce13
@ArthurZucker ArthurZucker added the for patch Tag issues / labels that should be included in the next patch label Apr 7, 2025
ArthurZucker pushed a commit that referenced this pull request Apr 7, 2025
@hiyouga @ArthurZucker
fix llama4 training (#37319)
2bf3d4a
cyr0930 pushed a commit to cyr0930/transformers that referenced this pull request Apr 18, 2025
@hiyouga
fix llama4 training (huggingface#37319)
8f7dc67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@Rocketknight1 Rocketknight1 Awaiting requested review from Rocketknight1

Assignees
No one assigned
Labels
for patch Tag issues / labels that should be included in the next patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiyouga @ArthurZucker