Standardize FSMT class naming: PretrainedFSMTModel → PreTrainedFSMTModel#39209
Open
VXXXO wants to merge 2 commits into
Open
Standardize FSMT class naming: PretrainedFSMTModel → PreTrainedFSMTModel#39209VXXXO wants to merge 2 commits into
VXXXO wants to merge 2 commits into
Conversation
…odel - Rename PretrainedFSMTModel to PreTrainedFSMTModel to match naming convention - Update all usages and exports accordingly - Fixes issue huggingface#39202
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: fsmt |
ArthurZucker
reviewed
Jul 7, 2025
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Hey! this is a breaking change! We can only do this with a deprecation cycle!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the naming inconsistency for the FSMT base model class, as described in issue #39202.
Changes
Renamed PretrainedFSMTModel to PreTrainedFSMTModel to match the naming convention used across the library (e.g., PreTrainedModel, PreTrainedTokenizer)
Updated all usages and exports accordingly
Added a comment to the class definition for clarity
Testing
✅ All imports work correctly
✅ Python syntax is valid
✅ No breaking changes to functionality
✅ All FSMT classes import successfully
This change improves code consistency and readability without affecting functionality.
Fixes: #39202