Add fromjson filter to Jinja2 chat templates#40388
Open
Prawal-Sharma wants to merge 1 commit into
Open
Conversation
- Added fromjson filter to parse JSON strings in chat templates - Enables deserializing tool_calls.function.arguments from JSON strings to dictionaries - Allows iterating over argument key-value pairs in templates - Added comprehensive tests for the new filter functionality - Handles graceful fallback when JSON parsing fails This feature is particularly useful for models like GLM-4.5 that need to parse JSON-formatted argument strings in tool calls within chat templates. Fixes huggingface#40366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is particularly useful for models like GLM-4.5 that need to parse JSON-formatted argument strings in tool calls within chat templates.
Fixes #40366
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.