Add ability to run Gemma 2 models without post layer norm#40670
Open
amer-sinha wants to merge 1 commit into
Open
Add ability to run Gemma 2 models without post layer norm#40670amer-sinha wants to merge 1 commit into
amer-sinha wants to merge 1 commit into
Conversation
940ad76 to
f8f3264
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma2, t5gemma |
…t feedforward norm
f8f3264 to
eadadbc
Compare
vasqu
reviewed
Sep 4, 2025
vasqu
left a comment
Collaborator
There was a problem hiding this comment.
Are there any models that use this? We usually only support features that are already included in (to be) published models
Member
|
Indeed! As @vasqu said, the best is to create a new model with modular (it will require very little code and efforts with modular)! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds the ability for Gemma2 models to run without post attention layer normalization and post feedforward layer normalization.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.