Fix: add num_hidden_layers property to T5GemmaConfig and add test for use_cache#41077
Open
priyankabolem wants to merge 1 commit into
Open
Fix: add num_hidden_layers property to T5GemmaConfig and add test for use_cache#41077priyankabolem wants to merge 1 commit into
priyankabolem wants to merge 1 commit into
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: t5gemma |
Author
|
Local pytest for t5gemma passes. The failing CI jobs seem unrelated. Please advise if changes are needed. |
Collaborator
|
Hi @priyankabolem Could you share an example (or a test in the library) that is failing prior to this PR? |
Author
|
Hi @ydshieh, thanks for the feedback! I ran the test locally before and after the fix to confirm the issue:
This shows that the fix (adding |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in T5GemmaConfig where the configuration did not expose num_hidden_layers, which is required by generation/cache utilities (use_cache=True).
• Added num_hidden_layers property to T5GemmaConfig.
• Ensured fallback to decoder’s layer count if not set explicitly.
• Added a unit test (test_generation_t5gemma.py) to verify generation runs successfully with cache enabled.
Testing
• Added test_generate_use_cache_works_for_t5gemma.
• Verified test passes locally with pytest.