Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable flake8-pie rules#41794

Open
cyyever wants to merge 5 commits into
huggingface:mainfrom
cyyever:pie_fixes2
Open

Enable flake8-pie rules#41794
cyyever wants to merge 5 commits into
huggingface:mainfrom
cyyever:pie_fixes2

Conversation

@cyyever

@cyyever cyyever commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR enables all flake8-pie rules in ruff. These rules are:

PIE790   Unnecessary pass statement
PIE794   Class field {name} is defined multiple times 
PIE796   Enum contains duplicate value: {value}  
PIE800   Unnecessary spread ** 
PIE804   Unnecessary dict kwargs  
PIE807   Prefer {container} over useless lambda 
PIE808   Unnecessary start argument in range  
PIE810   Call {attr} once with a tuple

@Rocketknight1

Rocketknight1 commented Oct 23, 2025

Copy link
Copy Markdown
Member

Adding more ruff rules so cc core maintainer @ArthurZucker

@Rocketknight1

Rocketknight1 commented Nov 17, 2025

Copy link
Copy Markdown
Member

gentle ping core maintainers @Cyrilvallez @ArthurZucker, since it's adding more ruff rules!

@cyyever cyyever force-pushed the pie_fixes2 branch 7 times, most recently from 5eb72f1 to 34d3f4b Compare November 20, 2025 08:07
cyyever added 2 commits January 1, 2026 17:10
@cyyever
Enable ruff PIE fixes
72affac 
Signed-off-by: Yuanyuan Chen <[email protected]>
@cyyever
More fixes
abe9341 
Signed-off-by: Yuanyuan Chen <[email protected]>
cyyever added 2 commits January 1, 2026 17:12
@cyyever
More fixes
5daab0f 
Signed-off-by: Yuanyuan Chen <[email protected]>
@cyyever
More fixes
8ed3c80 
Signed-off-by: Yuanyuan Chen <[email protected]>
@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: bert, bertweet, big_bird, clap, conditional_detr, convbert, detr, funnel, glm46v, glm4v, glm4v_moe, gpt_neo, gpt_sw3, instructblipvideo, internvl, layoutxlm

@cyyever
More fixes
a2e66c3 
Signed-off-by: Yuanyuan Chen <[email protected]>
@evalstate evalstate mentioned this pull request Apr 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyyever @Rocketknight1