docs: clarify recommended usage of max_new_tokens in generate()#42292
Open
hawon223 wants to merge 1 commit into
Open
docs: clarify recommended usage of max_new_tokens in generate()#42292hawon223 wants to merge 1 commit into
hawon223 wants to merge 1 commit into
Conversation
stevhliu
reviewed
Nov 20, 2025
stevhliu
left a comment
Member
There was a problem hiding this comment.
Thanks for adding a clarification!
| - compute_transition_scores | ||
|
|
||
|
|
||
| > **Note** |
Member
There was a problem hiding this comment.
I think it's better to include the recommendation in the docstring here rather than adding it on as a note at the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the documentation for the
generate()method by clarifying thatmax_new_tokensis now the recommended argument for controlling output length, whilemax_lengthremains for backward compatibility.Before submitting
Who can review?
@stevhliu