Fix tied_weights for vlms#42523
Merged
Merged
Conversation
…s into fix_weight_tying
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: kyutai_speech_to_text, llava_next_video, llava_onevision |
ArthurZucker
approved these changes
Dec 1, 2025
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
OK I think bart and seamless m4t and marian were the most proeminant to test
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sarathc-cerebras
pushed a commit
to sarathc-cerebras/transformers
that referenced
this pull request
Dec 7, 2025
* one fix * attempt mistral3 * empty dict * that was olmoe's problem * current CI status? * actual CI status * simplify * hmm? * bird * force tie word embeddings to false * specifics of FSMT * wrong reference? * finalize * fixup * weird mamba error * fix tied weights * hack musicgen * tie_encoder_decoder workaround * revert unwanted changes * hardcode llava onevision * more * revert * fix * modular * modular --------- Co-authored-by: Pablo Montalvo <[email protected]> Co-authored-by: Pablo Montalvo <[email protected]>
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* one fix * attempt mistral3 * empty dict * that was olmoe's problem * current CI status? * actual CI status * simplify * hmm? * bird * force tie word embeddings to false * specifics of FSMT * wrong reference? * finalize * fixup * weird mamba error * fix tied weights * hack musicgen * tie_encoder_decoder workaround * revert unwanted changes * hardcode llava onevision * more * revert * fix * modular * modular --------- Co-authored-by: Pablo Montalvo <[email protected]> Co-authored-by: Pablo Montalvo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Minimum fix from #42385