Fix _set_model_specific_special_tokens to accept list-format extra_special_tokens#44781
Closed
bensons wants to merge 5 commits into
Closed
Fix _set_model_specific_special_tokens to accept list-format extra_special_tokens#44781bensons wants to merge 5 commits into
_set_model_specific_special_tokens to accept list-format extra_special_tokens#44781bensons wants to merge 5 commits into
Conversation
…_special_tokens` Some model repos (e.g. jedisct1/Qwen3-Embedding-8B-q8-mlx) provide `extra_special_tokens` as a list in their tokenizer_config.json, which caused an `AttributeError: 'list' object has no attribute 'keys'`. This converts list inputs to a dict mapping each token to itself before processing. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Member
|
Please provide the excat model where this happens before we review. Also, we do not want new test files |
Author
|
Example that caused me to find this behavior: |
Collaborator
|
I'm able to load |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some model repos provide
extra_special_tokensas a list in their tokenizer_config.json, which caused anAttributeError: 'list' object has no attribute 'keys'. This converts list inputs to a dict mapping each token to itself before processing.Co-Authored-By: Claude Opus 4.6 [email protected]
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Cyrilvallez
@itazap
@ArthurZucker