[Sam3LiteText] Remove unnecessary modules/configs#45535
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
Apr 21, 2026
vasqu
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, more proper modular usage is always good 🫡
Collaborator
|
run-slow: sam3_lite_text |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: sam3_lite_text |
Contributor
|
This comment contains models: ["models/sam3_lite_text"] |
Merged
This was referenced Apr 23, 2026
eustlb
pushed a commit
that referenced
this pull request
May 12, 2026
* fix sam3 lite text * sync modular --------- Co-authored-by: vasqu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed that some last minute modifications to modular in #44320 added unnecessary configs and modules in the modeling code
Cc @vasqu, @NielsRogge