Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[nit] glmasr should be in AutoModelForMultimodalLM#45670

Open
eustlb wants to merge 2 commits into
mainfrom
fix-asr-alm-automapping
Open

[nit] glmasr should be in AutoModelForMultimodalLM#45670
eustlb wants to merge 2 commits into
mainfrom
fix-asr-alm-automapping

Conversation

@eustlb

@eustlb eustlb commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

As per title.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

[
("cohere_asr", "CohereAsrForConditionalGeneration"),
("dia", "DiaForConditionalGeneration"),
("glmasr", "GlmAsrForConditionalGeneration"),

@zucchini-nlp zucchini-nlp Apr 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it is also missing audio/music Flamingo for generation, those are now mapped in AutoModel 🙈

@zucchini-nlp

Copy link
Copy Markdown
Member

Btw, i remembered one thing. Not sure if models are actually seq2seq, but the usage snippet on the hub currently uses AutoModelForSeq2Seq. Some of them looks like a common ALM from first glance

I think we need to either delete them from seq-2-seq mapping, or re-order a bit in update_metadata and deprecate seq2seq usage.

@eustlb

eustlb commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for the step back here, you totally right, this (as the others are) are not seq2seq. Never looked deep enough in this, the overall mapping for audio models makes little sence I guess. Taking a deeper look now and will come up with a follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants