pytorch 2.13 is released , updating transformer to handle the fix tf32 issue#47222
Open
khushali9 wants to merge 3 commits into
Open
pytorch 2.13 is released , updating transformer to handle the fix tf32 issue#47222khushali9 wants to merge 3 commits into
khushali9 wants to merge 3 commits into
Conversation
Merged
Contributor
Author
|
@vasqu @Rocketknight1 @ydshieh Can you please review, CI is failing because of security gate, but I have added version aware fix such that anyone using pytorch <2.13 would have no issue. Also moved those setter lines to appropriate method where it belongs (enable_tf32) and keeping is_torch_available() method clean. |
Contributor
Author
Contributor
|
Thank you for your contribution 🤗! CI Security Gate — automatic approval blockedThis PR was not automatically approved for CI because the security gate failed. Possible reasons:
See the workflow run for the exact violations. A maintainer can review and manually approve CI if a finding is a false positive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removing it again after 2.13 Pytorch release. @ydshieh Also I kept version check such that it does not break for pytorch <2.13.
This fix is no longer needed after issue#1 fixed by my on Pytorch
issue#2 does not need to be fixed, as we have so many ways to avoid it.
Basically dont use hasattr when you have already set fp32_precision generic/globally.
Fixes # (issue)
Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. These often are low-quality, or fix extremely minor issues that occur rarely or never in practice.
As a result, we're instituting a rule that first-time contributors should not use code agents to submit PRs or issues.
We'd also ask autonomous "OpenClaw"-like agents not to open any PRs or issues.
Issues/PRs from first-time contributors that violate this rule will probably just be closed without review, and we
might block you, especially if you open more than one or appear to be deliberately ignoring this. We especially do not
want new contributors to jump in on random issues to contribute an agent-written fix. This creates lots of noise
for reviewers and other users and will almost certainly get you blocked.
For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request checks?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.