Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Action Handle Names#6

Closed
adamdyson wants to merge 2 commits into
hummer2k:masterfrom
adamdyson:master
Closed

Action Handle Names#6
adamdyson wants to merge 2 commits into
hummer2k:masterfrom
adamdyson:master

Conversation

@adamdyson
Copy link
Copy Markdown

Issue #4

I wasn't able actually run the test suit with PHPUnit, your bootstrap class seems specific to your environment and where libraries are placed. However I'm confident that when you run this yourself, it'll work.

Cheers,
Adam

@hummer2k
Copy link
Copy Markdown
Owner

hummer2k commented Sep 4, 2015

Hi, first thanks for your pull request!
But Travis is failing :/
To run the testsuite locally you have to run composer install within the module directory and then run ./vendor/bin/phpunit

To check coding standards run
./vendor/bin/phpcs --standard=PSR2 ./src/

And to fix them:
./vendor/bin/phpcbf --standard=PSR2 ./src/

Unfortunately I see problems with your code: The same issue as in zendframework/zendframework#5670

For example: Vendor\SomeModule\Controller\Index::index
Result:

vendor
vendor-index
vendor-index-index

Maybe we just need to alter https://github.com/hummer2k/ConLayout/blob/master/src/ConLayout/Listener/ActionHandlesListener.php#L101 to:

$handleName = strtolower($this->inflector->filter(implode('-', $actionHandles[$i])));

The larger priority gap could then be achieved by just multiplying the counter $j by 10.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants