Fix unhandled exception when stopping app, fragile tests, and modernize CI - #1125
Open
davictran76 wants to merge 1 commit into
Open
davictran76 wants to merge 1 commit into
davictran76 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an unhandled runtime exception when stopping an application, corrects fragile test assertions, and modernizes the GitHub Actions CI matrix.
1. Fix crash when stopping an app (
index.js)dispatch(null),subscriptionsis reassigned to identity functionid. The guardif (subscriptions)evaluates to truthy, subsequently invokingid(null) -> nulland passingnullintopatchSubs, which throws an error.&& state != nullto ensure subscriptions are never patched once the application has terminated.2. Fix DOM node reference breakage in tests (
tests/index.test.js)node.parentNodeafter a dispatch failed when tags changed becausepatchcallsremoveChild, resettingparentNodetonull.containerbefore callingapp(), reading fromcontainer.childNodes[0]directly.div.style._props.colortodiv.style.color.3. Modernize CI matrix (
.github/workflows/ci.yml)[18.x, 20.x, 22.x].actions/checkoutandactions/setup-nodeto@v4.codecovglobal CLI.Checklist