Make ActiveRecord#find work with an id array (on base model or scope) + tests #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was really well done, in particular the specs. Yes any files in the batchx directories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a ruby/hyper-model/spec/batch7/aaa-unit_tests/ar_basics_spec.rb file.
I don't fully understand the dir structure under spec, don't know if the CI automatically picks up new files?
ActiveRecord#find is defined for the base model and for collections (scopes), has some code duplication.. same for the tests.
Please check this pull request, it's my first code contribution, earlier pull requests were for documentation.
This should close #184