forked from matplotlib/matplotlib
-
Notifications
You must be signed in to change notification settings - Fork 0
update #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dvi is a binary format that includes some ASCII strings such as TeX names of some fonts. The associated files such as psfonts.map need to be ASCII too. This patch changes their handling to keep them as binary strings all the time. This avoids the ugly workaround try: result = some_mapping[texname] except KeyError: result = some_mapping[texname.decode('ascii')] which is essentially saying that texname is sometimes a string, sometimes a bytestring. The workaround masks real KeyErrors, leading to incomprehensible error messages such as in #6516.
So if you follow the troubleshooting instructions and rerun with --verbose-helpful you get a hint about the usual reason for #6516.
If the class has an internal error triggering this assertion, we will get some errors later from mixing strings and bytestrings.
These are now ASCII bytestrings so we should not assume they are strings.
Don't mix filenames and dvi font names as keys of the same dict.
Use re.findall, and open the file as binary.
Improve a docstring, remove unneeded parens from an assert, open a file as binary instead of encoding each line read from it, don't call six.b on variable strings, simplify string handling, improve the formatting of a matplotlib.verbose.report call.
Combine the word splitting and classification in one regex so we only have to scan each line once. Add some quotation marks in the test case to check that we are handling quoted words correctly (the behavior should always have matched this test case).
I'm so very confused so trying to demystify how this works. @QuLogic
Once all the parameters are substituted into the warning message, it doesn't make grammatical sense due to some assumptions in the message.
Seems to be an obvious omission
DOC: Fixed x, y, docstring in errorbar
* Add README.txt documenting how to use the script to generate gitwash docs.
Update Slider docs and type check slidermin and slidermax.
Clean up and move text rotation example
Handle dvi font names as ASCII bytestrings
Support for setting the backend with `-dbackend` was deprecated in 1.5.
Regenerate the gitwash docs.
API: Remove support for -dbackend argv.
Deprecate Axes.axesPatch, Figure.figurePatch.
DOC: Add a code block in 'installing' docs.
Fixes typos in Artist tutorial
DOC: Fix small typos in 'eventplot' docstring
Python 3.4 does not automatically import module `abc` into `collections`, causing an error when checking for `collections.abc.MappingView`. Use `collections.MappingView` to work round this difference. At some point Python may deprecate `collections.MappingView` in favor of `collections.abc.MappingView` but we can fix that when it arises.
MAINT: mappingview check for Python 3.4
Addresses #8177, Readme badges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.