-
Notifications
You must be signed in to change notification settings - Fork 18
chore: Add tests #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Antonov548: Interesting things happen when this PR is run with the dev version of igraph. Example: Can you confirm? Is the current dev version of igraph reversing source and target vertices for edges in some way? |
I will take a look. Thanks. |
|
Introduced in igraph/rigraph@aa055c209 . |
|
But this is just the trigger, probably not the root cause. |
Yes, I think I know where is problem. Because in CC: @szhorvat |
|
Looks like we have this sorted out. |
No, there isn't. I still don't quite understand why it is not possible (or why it is disadvantageous) to store a flat edgelist in the R-side igraph object. @krlmlr Could you please explain your reasoning again at tomorrow's meeting? It would be good to write down what versions of the igraph object exist, how the format upgrade mechanism works, and what constraints it imposes on potential future changes. We need to get this right, and have a clear (and documented) procedure for any future format changes. Part of the reason why there's so much confusion now is that the format change procedure wasn't documented from the get-go, so now we have to figure everything out from scratch. |
to make sure the upcoming igraph release doesn't break anything.