Fix aio_stop_event #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It even fixed one of the two failing tests. Unintentionally 😅 |
Codecov Report
@@ Coverage Diff @@
## dev #93 +/- ##
==========================================
+ Coverage 48.73% 50.11% +1.38%
==========================================
Files 13 13
Lines 1303 1303
Branches 130 130
==========================================
+ Hits 635 653 +18
+ Misses 656 638 -18
Partials 12 12
|
Contributor
Author
|
I fixed the last failing test as well. It never reached |
Contributor
Author
|
Can this PR be merged (after #96 is merged)? It would make developing for me a bit easier. |
Owner
|
Yes sorry give me a few hours and I will merge both |
Contributor
Author
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #83,
asyncio.Event()needs to be called with theloopparameter. Otherwise it throws an error when not executed in the main thread.