Fix RemoveAll implementation #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluvadev
approved these changes
Jan 28, 2023
Owner
iluvadev
left a comment
There was a problem hiding this comment.
Thanks!
You are right, a collection used in a foreach must be immutable. A foreach can not be used to add or remove elements.
Sorry for that!
Collaborator
Author
|
I appreciate your approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a element of enumerable in foreach is not allowed to do. It throws exception if you do that.
PR includes fixes, but I'm not sure this code is covering all. At least, it worked on my environment without any exceptions.