Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove NO_ALPHA flag insertion in ColorPicker4::build #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2021
Merged

Remove NO_ALPHA flag insertion in ColorPicker4::build #579

merged 1 commit into from
Dec 4, 2021

Conversation

kazatsuyu
Copy link
Contributor

ColorEditFlags::NO_ALPHA is used in ColorPicker4::build function, so there is no way to edit alpha value.
It was probably copied from ColorPicker3::build and should be removed.

@dbr
Copy link
Contributor

dbr commented Dec 4, 2021

Ahh I briefly confused the ColorEdit with the ColorPicker! ColorPicker4 which is the "inline color swatch" widget, and it indeed is permanently missing the alpha without this fix:

no_alpha_bug

Looks good, shall merge once all the CI bits are happy! Thanks!

@dbr dbr merged commit 352b5d0 into imgui-rs:main Dec 4, 2021
@kazatsuyu kazatsuyu deleted the fix/color-picker-alpha branch December 4, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazatsuyu @dbr