Backport text-input bug fixes for 0.8.1 #581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, why is this going into main? Don't we want this in a new branch? |
|
Oh yes good point, I wasn't clear! I don't intend this PR to be merged - these changes are already in the I've marked it as a draft to avoid the lure of clicking merge |
Merged
We should probably publicly document the features we're exposing so they're more easy to find :-)
|
okay @dbr @cosmicchipsocket let me know what you think? I think this is good to publish now |
|
Looks good to me! |
|
I haven't found any issues during my usage of the branch. |
|
about to publish -- instead of a PR, did it as a seperate branch on the repo. i probably could have done that with this PR, but wasn't sure how! |
|
aaah you had already done that. I am so sorry haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't quite realize there was over 100 commits since v0.8.0 (:partying_face:), so I might have missed something but I think this covers the bugfixes relating to the text input bugs
Backports the following changes:
Relates to #564 #546 #553
Also there didn't seem to be any existing conventions for release-maintenance branch naming (I would normally use
maint-0.8but interferes in minor way with tab-complete formain)