Hi guys,

I'm trying to investigate the cause behind the failing linter from
22 days ago (linter 1.54)
https://github.com/imgui-rs/imgui-rs/runs/4710306933?check_suite_focus=true

It seems that the linter is throwing errors with the public enum
template types(?) within winit-0.26.0, ie:

EventLoop<T: 'static>
EventLoopWindowTarget<T: 'static>
EventLoopProxy<T: 'static>
EventLoopWindowTarget

Which are located in
/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.26.0/src/platform_impl/linux/mod.rs
and
/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.26.0/src/event_loop.rs

It seems the error is due to unused parameters.

Is this something that could be solved on imgui-rs's end,
or something I should bring up with the winit team?

Thank you!

ZM

Thanks for looking into that! I only briefly glanced at the lint failures, didn't realise it was coming from winit, interesting..

I wonder if the "error: Please select a feature to build for unix: x11, wayland" error is the main one to worry about, and the subsequent unsed-parameters errors are side-effects of that as the mentioned parameter appear to be used, e.g:

https://github.com/rust-windowing/winit/blob/v0.26.0/src/event_loop.rs#L32-L33

Hmmm, actually, the solution might be even simpler.. The failing clippy command is

cargo clippy --manifest-path imgui-winit-support/Cargo.toml --all-features --all-targets

from here:

..which just isn't present in current main branch

So we should probably just remove (as done here)