TextCallbackData::selection causes problems when selecting from right to left #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when working with callbacks on an
InputText
, it's possible forTextCallbackData::selection()
to return a range withstart
>end
, eg. when selecting text by dragging from right to left. One resulting problem is that when you do this,TextCallbackData::has_selection()
will return false, because the implementation is simplywith stdlib's implementation of
Range::is_empty()
beingA bigger problem is that calling
TextCallbackData::selected()
with the selection in this state will cause a guaranteed panic, because the selection range is used to index the input buffer.This MR provides one possible solution by ensuring the
Range
returned byTextCallbackData::selection()
always satisfiesstart
<=end
.