glow: move vertex creation to same method as deletion #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents leak if set_up_render_state is called without calling render Closes imgui-rs#643
jmaargh
reviewed
May 28, 2022
imgui-glow-renderer/src/lib.rs
Outdated
Comment on lines
6
to
10
| //! It is important to note this renderer's API is not foolproof. It was designed | ||
| //! more for simplicity and control (allowing the user to manually have some control | ||
| //! over the GL state) than as a production-ready fully-general API. This control is | ||
| //! why so many things are `pub`. | ||
| //! |
There was a problem hiding this comment.
I'd suggest removing this and instead extending the "Scope" section of the docs to something like this:
//! Consider this an example renderer. It is intended to be sufficent for simple
//! applications running imgui-rs as the final rendering step. If your application
//! has more specific needs, it's probably best to write your own renderer, in
//! which case this can be a useful starting point. This renderer is also not
//! foolproof (largely due to the global nature of the OpenGL state). For example,
//! a few "internal" funcitons are marked `pub` to allow the user more
//! fine-grained control at the cost of potential rendering errors.
thomcc
approved these changes
May 31, 2022
|
@thomcc As well as simplifying shared-state management, the upstream example notes that this allows the renderer to work across multiple OpenGL contexts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #643
(cc @Selicre @jmaargh )