Fix keyboard modifiers in Winit with the new ImGui version. #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, quite right - no idea how I didn't spot this, I was sure I tested modifier keys were working! 🤷 Thanks for this! Pushed a minor fix, shall merge when CI is happy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent update to DearImGui 1.89.2 was great, but I think it broke the handling of modifier keys.
The thing is that the values of
io.key_shiftand friends are updated inImGui::UpdateKeyboardInputs()based on the values of the pseudo keys such asImGuiMod_Ctrl.It looks like the recommended way to notify changes in the modifier keys is to just call
AddKeyEvent(), as if it were a real key.