Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated winit, glutin and glium dependencies #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2023
Merged

Updated winit, glutin and glium dependencies #754

merged 1 commit into from
Dec 14, 2023

Conversation

Rob2309
Copy link
Contributor

@Rob2309 Rob2309 commented Nov 18, 2023 •
edited
Loading

This PR updates winit to 0.29, glutin to 0.31 and glium to 0.33.
Currently, the crates.io release of glium is not compatible with the other dependencies. Until this is fixed, this PR uses a patch to use the git version of glium instead, which is compatible already. Thus, until crates.io is updates, this PR probably should not be merged.

The new key handling of winit seems very unintuitive to me, so someone checking the updated key handling code would be appreciated.

@sanbox-irl
Copy link
Member

Thanks for this Thus, until crates.io is updates, this PR probably should not be merged. unfortunately, yes, that's why we haven't updated. I am not very pleased with that!

@sanbox-irl
Copy link
Member

Actually looks like glium finally published 0.33 a few weeks ago!

@sanbox-irl
Copy link
Member

Actually, that release didn't update their deps enough for us (I believe -- it's awfully difficult to track these). I suspect it might still be worth merging though, since at least then we could point users to using as a git dep instead of from crates.io

@Rob2309
Copy link
Contributor Author

Rob2309 commented Nov 30, 2023

So is there currently anything I can do for this PR?

@Sewer56
Copy link

Sewer56 commented Dec 14, 2023

It's not super urgent in any manner, but I should note in any case that I'm unable to run any of the examples under Wayland without this patch. Neither glow or glium. After this patch, both work without any issue whatsoever.

@sanbox-irl sanbox-irl merged commit ca05418 into imgui-rs:main Dec 14, 2023
This was referenced Jan 10, 2024
Closed
Merged
@mkrasnitski mkrasnitski mentioned this pull request Jan 31, 2024
Closed
@Rob2309 Rob2309 mentioned this pull request Feb 13, 2024
Closed
@parasyte parasyte mentioned this pull request Apr 7, 2024
Closed
@colinmarc colinmarc mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rob2309 @sanbox-irl @Sewer56