fix: improve form control focus visibility#28512
Merged
alextran1502 merged 2 commits intoMay 20, 2026
Merged
Conversation
Member
Contributor
Author
|
I checked the user edit form. It uses the @immich/ui Input/NumberInput focus-within primary ring styling. I updated |
alextran1502
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Refs #19498
Adds a visible focus ring for
.immich-form-inputcontrols so keyboard focus is easier to identify on admin settings inputs, selects,and textareas.How Has This Been Tested?
prettier --check src/app.cssScreenshots
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
Used an LLM to help inspect the issue, set up the local environment, and validate the change. I reviewed the final diff before submitting.