Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: improve form control focus visibility#28512

Merged
alextran1502 merged 2 commits into
immich-app:mainfrom
Caltsic:fix/focus-visible-input-outline
May 20, 2026
Merged

fix: improve form control focus visibility#28512
alextran1502 merged 2 commits into
immich-app:mainfrom
Caltsic:fix/focus-visible-input-outline

Conversation

@Caltsic

@Caltsic Caltsic commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

Refs #19498

Adds a visible focus ring for .immich-form-input controls so keyboard focus is easier to identify on admin settings inputs, selects,and textareas.

How Has This Been Tested?

  • Verified keyboard focus on Job Settings number inputs
  • Verified keyboard focus on Logging level select
  • Ran prettier --check src/app.css

Screenshots

focus-level-select focus-number-input

Checklist:

  • I have carefully read CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Please describe to which degree, if any, an LLM was used in creating this pull request.

Used an LLM to help inspect the issue, set up the local environment, and validate the change. I reviewed the final diff before submitting.

@Caltsic Caltsic marked this pull request as ready for review May 20, 2026 12:00
@Caltsic Caltsic requested a review from danieldietzler as a code owner May 20, 2026 12:00
@Caltsic Caltsic changed the title Improve form control focus visibility fix(web): improve form control focus visibility May 20, 2026
@Caltsic Caltsic changed the title fix(web): improve form control focus visibility fix: improve form control focus visibility May 20, 2026
@alextran1502

Copy link
Copy Markdown
Member
image

Can you help check if your change is similar to the styling made for the user edit form?

@Caltsic

Caltsic commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

I checked the user edit form. It uses the @immich/ui Input/NumberInput focus-within primary ring styling. I updated .immich-form-input to use the same ring-based focus styling instead of a separate box-shadow. No new component was added.

@alextran1502 alextran1502 merged commit b414b3d into immich-app:main May 20, 2026
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants