Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Broken documentation links. #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagstuan opened this issue Sep 29, 2017 · 6 comments · Fixed by #1315
Closed

Broken documentation links. #1313

dagstuan opened this issue Sep 29, 2017 · 6 comments · Fixed by #1315

Comments

@dagstuan
Copy link

The links on http://facebook.github.io/immutable-js/docs/ currently seem to be broken. Nothing happens when clicking the links such as Map, List etc. in the right-menu.

@robininfo-edsx
Copy link

robininfo-edsx commented Sep 29, 2017

I don't have this problem, as it be resolve ?
If not, can you give us:

  • You web browser and this version
  • Errors and warnings you can get from your inspector

@remmycat
Copy link
Contributor

remmycat commented Sep 29, 2017

Same here.
When i navigate to e.g. List it still shows the overview (with url https://facebook.github.io/immutable-js/docs/#/List ), but in a new tab.
When i then click again on a List link, in the new tab, the link directs to https://facebook.github.io/List

This seems to be specific for some links, some work properly.

Screenshot of console error attached.
The error comes first when clicking on a broken link.
Latest MacOs Sierra + Latest Chrome 61

screen shot 2017-09-29 at 10 52 58

Also in the overview, directly after the first error after clicking on List, this additional error is shown, that doesn't say much:
screen shot 2017-09-29 at 10 59 52

@olieidel
Copy link

olieidel commented Sep 29, 2017

+1. Also in the current Firefox Developer Edition.

edit: Archive Link of the docs if you prefer working links.

@gcoderre
Copy link

All docs broken, indeed ;(

@lanescherber
Copy link

lanescherber commented Sep 29, 2017

On https://facebook.github.io/immutable-js/docs/#/ using Chrome stable 61.0.3163.79 macOS 10.12.6:

clicking the "List" link in the right sidebar index gives the following console error:
Uncaught Error: Unknown kind undefined at p (Defs.js:341) at Defs.js:315 at Array.reduce (<anonymous>) at p (Defs.js:315) at Defs.js:337 at Array.reduce (<anonymous>) at p (Defs.js:336) at i (Defs.js:268) at r (Defs.js:261) at t.render (Defs.js:52)
and so does OrderedSet, Stack, and maybe more.

Clicking "Map" (and some other links) opens the expanded content as expected. Links that fall under "Map" are working and properly scroll the page to the relevant content.

At one point the href for the links in the sidebar was set to the bare hostname https://facebook.github.io/List instead of https://facebook.github.io/immutable-js/docs/#/List but now I can't seem to replicate it.

@jhonymoncada
Copy link

jhonymoncada commented Sep 29, 2017

+1

I have the same issue:

Defs.js:341 Uncaught Error: Unknown kind undefined at p (Defs.js:341) at Defs.js:315 at Array.reduce (<anonymous>) at p (Defs.js:315) at Defs.js:337 at Array.reduce (<anonymous>) at p (Defs.js:336) at i (Defs.js:268) at r (Defs.js:261) at t.render (Defs.js:52)

remmycat added a commit to remmycat/immutable-js that referenced this issue Sep 29, 2017
errendir added a commit to errendir/immutable-js that referenced this issue Sep 30, 2017
…ings

* facebook/master: (48 commits)
  4.0.0-rc.3
  Use latest immutable.js build on website
  Only build docs on tagged releases (immutable-js#1321)
  Relicense as MIT (immutable-js#1320)
  Fix rendering issue on tall screens
  Merge immutable-js#1285
  Do not throw from hasIn (immutable-js#1319)
  Add more flow tests for Records
  Upgrade prettier and jest (immutable-js#1318)
  Merge immutable-js#1193
  Minor flow record fixes
  Merges immutable-js#1195
  fixed immutable-js#1290 by removing relative position from star count (immutable-js#1317)
  Fix deploy script
  Adds a script which automatically builds a #npm branch (immutable-js#1316)
  Use .github directory
  Merges immutable-js#1314
  Flow config ignore all node_modules
  Update to latest version of flow (immutable-js#1312)
  fixed immutable-js#1313 by fixing two borked reducers (immutable-js#1315)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants