[WIP] Lint tests with `tslint` and `eslint`. #1129

avocadowastaken · 2017-03-09T16:03:58Z

No description provided.

avocadowastaken · 2017-03-10T08:11:30Z

Specifically the ts-jest changes are controversial and reduce test coverage, so I'd like to discuss those in isolation

TSLint suggested to remove ///<reference path='../resources/jest.d.ts'/> declarations in favor of tsconfig.json.

Current resources/jestPreprocessor.js does not supports tsconfig.json (and i'm not familiar with this typescript api 😓) so I add ts-jest again.

Both resources/jestPreprocessor.js and ts-jest gave same output:

Test Suites: 36 passed, 36 total
Tests:       482 passed, 482 total
Snapshots:   0 total

avocadowastaken · 2017-03-10T09:22:04Z

Something went wrong after merging latest updates from master

Lint tests with tslint and eslint.

482f665

facebook-github-bot added the CLA Signed label Mar 9, 2017

avocadowastaken added 2 commits March 9, 2017 20:08

Update arrow-parens rule in tslint to leverage changes.

0831a8f

Remove useless whitespaces around type definitions to leverage changes.

7d65e14

avocadowastaken changed the title ~~Lint tests with tslint and eslint.~~ [WIP] Lint tests with tslint and eslint. Mar 9, 2017

avocadowastaken added 3 commits March 10, 2017 11:43

Fxi tsconfig.json, reformat code to leverage changes.

5ef0e88

Reformat code, use string literals.

8e6cd99

Add ts-jest.

82e6e26

avocadowastaken closed this Mar 10, 2017

avocadowastaken deleted the lint-tests branch March 10, 2017 09:21

Provide feedback