You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change updates the tests to report that the actual type inferred by tsc is correct. It would be easy to make the existing tests pass by changing the order of the overloadings in immutable.d.ts, but in this case I believe tsc is doing the right thing: it can't automatically infer the correct type of the values returned by fromKeys, so it's better to infer the type as unknown.
Odd. I see dtslint is reporting an error under Typescript 4.9, but for me, it's fine with my changes, but without them it reports an error with Typescript 5.0.
Ok, I'm getting more reasonable results after running npm ci. The trouble is that either way the test is written, it fails with either TS 4.9 or 5.0. It's still possible to make the tests pass by swapping the order of overloads in immutable.d.ts as lines 1716-1717 and 1939-1940, but I still think that's a bad idea, and the new behavior of tsc is more correct. For now I think the best solution is to remove those two type tests entirely; what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the tests to report that the actual type inferred by tsc is correct. It would be easy to make the existing tests pass by changing the order of the overloadings in immutable.d.ts, but in this case I believe tsc is doing the right thing: it can't automatically infer the correct type of the values returned by
fromKeys, so it's better to infer the type asunknown.