Revert previous assertion as it introduced a regression #2102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems reasonable to assert that keys shouldn't be undefined, since keys are supposed to be of type PropertyKey (string | number | symbol). But in practice, JavaScript allows undefined as a key by implicitly converting it to the string "undefined". This caused a regression specifically in the `groupBy` function, where the grouper callback can return undefined for some items. That behavior was previously supported and is now broken by the assertion. Long-term, it probably makes sense to tighten this up and only allow real PropertyKeys, but that’ll need a more careful cleanup.
|
Output diff failing test is under control as we change a TS file that does change the builded output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseed #2100
Revert a change introduced in Commit 53237d2.
Previously, grouping by a function that might return
undefinedwas tolerated, but in the latest version, this now throws.This PR does add @giggo1604 changes, but improve the TS typing directly