Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make it obvious that a Record is a Map #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make it obvious that a Record is a Map #668

wants to merge 1 commit into from

Conversation

johnnyreilly
Copy link

and so shares the API of Map. I only discovered this by accident so it seems potentially worth emphasing?

and so shares the API of Map.  I only discovered this by accident so it seems potentially worth emphasing?
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@rawls238
Copy link
Contributor

Given this issue #505 I don't think we want to emphasize this since it should not share exactly the same API as Map

@johnnyreilly
Copy link
Author

That's a fair point. That said, the docs don't presently detail how one changes a record (using set, update etc) at all. That should be corrected and guidance given I think.

@ir-fuel
Copy link

ir-fuel commented Nov 22, 2015

Johnny has a point. Right now the docs only show definition, construction and field removal. I wasn't aware of the other methods until I stumbled upon this issue.

@leebyron
Copy link
Collaborator

This is actually just an implementation detail, and one that's likely to change in the future. It's a "Map" in the sense that it exposes get and set methods, but the HOF methods like filter and forEach make no sense on a Record.

@leebyron leebyron closed this Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants