[utils] [fix] parse: Also delete parserOptions.projectService
#3039
Conversation
b576a40 to
d3f3b92
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3039 +/- ##
===========================================
- Coverage 96.02% 81.74% -14.29%
===========================================
Files 78 86 +8
Lines 3299 3839 +540
Branches 1160 1266 +106
===========================================
- Hits 3168 3138 -30
- Misses 131 701 +570 ☔ View full report in Codecov by Sentry. |
|
The change is simple, but we're not testing on v6 of that parser, let alone v8 yet. I think we need to add those tests first. (related, jsx-eslint/eslint-plugin-react#3629) |
|
Hi @ljharb ! |
|
What v6 changes did i accept without testing in v6? |
The PR I mentioned (#2963) is the exact same as this one - it adds support for projectservice, which was introduced in v6 of ts-eslint by deleting a new property named |
|
Fair point, I’ll stick to that precedent here then. cc @JoshuaKGoldberg @bmish to confirm this is all that’s needed? |
d3f3b92 to
c387276
Compare
parse: Also delete parserOptions.projectService
|
eslint-module-utils v2.8.2 is now published, with this change. |
… in eslint-module-utils v2.8.2 import-js/eslint-plugin-import#3039
Recently typescript-eslint released version 8. One of the breaking changes introduced there was renaming
EXPERIMENTAL_useProjectServicetoprojectService.xref: https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/#project-service
This fix deletes the new property as well to let this plugin be compatible with v8. During my testing I didn't encounter any other issues than this.
Change is based on prior change to get project service option working:
ref #2963