Fix the loss of large, merged packets#158
Merged
Merged
Conversation
Owner
|
Hey, that's awesome! Good job. |
Collaborator
Author
|
As I understand it, it's the sort of maximum size that it can read in. The default size is 4096, but during my debugging, I found that smaller ones were still let through. I think it just acts as a maximum size with the trade-off being more memory is allocated. |
Owner
|
Sounds great. Doesn't seem to be using more resources in a noticeable way for me. Let's go for it. Thank you very much for your hard work on this! Solid job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A good thing I took a second look at this. Just bumping the read_buffer_size to the max allowed by the kernel solves the problem. One line in one file!
Wild how it can make so much of a difference...
Here is the current (master) bandwhich on the left, wget in the middle, and this patched version on the left: https://imgur.com/HmDyaOe