Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Honor filter flags when using raw mode#174

Merged
imsnif merged 1 commit into
imsnif:mainfrom
sigmaSd:honor_flags_in_rawmode
Jul 13, 2020
Merged

Honor filter flags when using raw mode#174
imsnif merged 1 commit into
imsnif:mainfrom
sigmaSd:honor_flags_in_rawmode

Conversation

@sigmaSd
Copy link
Copy Markdown
Collaborator

@sigmaSd sigmaSd commented Jul 12, 2020

Hi, currently when using --raw flag bandwhich doesn't respect the filter flags ('-a', '-c', '-p'), this pr addresses that.

@sigmaSd sigmaSd changed the title Honor RenderOpts flag when using raw mode Honor RenderOpts flags when using raw mode Jul 12, 2020
@sigmaSd sigmaSd changed the title Honor RenderOpts flags when using raw mode Honor filter flags when using raw mode Jul 12, 2020
@sigmaSd
Copy link
Copy Markdown
Collaborator Author

sigmaSd commented Jul 12, 2020

Also I want to suggest adding a separator message between each output cycle, for example nethogs writes "Refreshing:" as header and "\n\n" as footer, this allows parsing it in a simple manner.

@imsnif
Copy link
Copy Markdown
Owner

imsnif commented Jul 13, 2020

Hey @sigmaSd, thanks for finding and fixing this. Looks good. I'd definitely be open to the change you mentioned. Feel free to open an issue or a PR, as you prefer. Thanks for this!

@imsnif imsnif merged commit 5bc35a4 into imsnif:main Jul 13, 2020
@sigmaSd
Copy link
Copy Markdown
Collaborator Author

sigmaSd commented Jul 13, 2020

Thanks as well! @imsnif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants