Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Extend installation steps with sudo-able paths#42

Merged
imsnif merged 5 commits into
imsnif:masterfrom
LoyVanBeek:LoyVanBeek-patch-1
Jan 2, 2020
Merged

Extend installation steps with sudo-able paths#42
imsnif merged 5 commits into
imsnif:masterfrom
LoyVanBeek:LoyVanBeek-patch-1

Conversation

@LoyVanBeek
Copy link
Copy Markdown
Contributor

Fixes #30

@jbpratt
Copy link
Copy Markdown

jbpratt commented Dec 30, 2019

Hey @LoyVanBeek , it seems that the project has updated it's name. Would you mind making the changes to reflect this?

@LoyVanBeek
Copy link
Copy Markdown
Contributor Author

Bandwhich, great name. PR is updated.

Comment thread README.md Outdated
Copy link
Copy Markdown
Owner

@imsnif imsnif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work collecting all the solutions!

I would very much like to add it to the README (I think it will save people a lot of time opening and responding to issues), but maybe we can have it in its own special Troubleshooting section?

Maybe between "raw_mode" and "Contributing" (on the same header level as "Contributing")?
Then this can be under a sub-header of "Installing with Cargo" or something else you feel makes sense? What say you?

@LoyVanBeek
Copy link
Copy Markdown
Contributor Author

These staps ere required to get bandwhich working at all, so I'd considered them part of installation. Troubleshooting would be for other types of problems perhaps.

@Calinou
Copy link
Copy Markdown
Contributor

Calinou commented Jan 1, 2020

I've opened #57, which may be an easier solution than the one proposed here. I don't think it works on macOS though, so we may want to document both.

@imsnif
Copy link
Copy Markdown
Owner

imsnif commented Jan 2, 2020

@LoyVanBeek - fair point :)

I moved some stuff around your changes to make things clearer. Thank you very much for this!

@imsnif imsnif merged commit 43618d3 into imsnif:master Jan 2, 2020
zhangxp1998 pushed a commit to zhangxp1998/bandwhich that referenced this pull request Jan 2, 2020
* Extend installation steps with sudo-able paths

Fixes imsnif#30

* Change name to 'bandwhich'

* Add setcap option for installation

* Fix typo and make path uniform with other options

Co-Authored-By: Oleksii Filonenko <[email protected]>

* docs(readme): rework sections

Co-authored-by: Oleksii Filonenko <[email protected]>
Co-authored-by: Aram Drevekenin <[email protected]>
zhangxp1998 pushed a commit to zhangxp1998/bandwhich that referenced this pull request Jan 3, 2020
* Extend installation steps with sudo-able paths

Fixes imsnif#30

* Change name to 'bandwhich'

* Add setcap option for installation

* Fix typo and make path uniform with other options

Co-Authored-By: Oleksii Filonenko <[email protected]>

* docs(readme): rework sections

Co-authored-by: Oleksii Filonenko <[email protected]>
Co-authored-by: Aram Drevekenin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation to ~/.cargo/bin/what prevents sudo usage

5 participants