GOPHERS-1255: Fixing go-opine errors on OSX #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem on OSX is warnings from the linker showing up as "build-output" actions but without a corresponding "build-fail". There is no "build-success" or any such similar build action, so these warnings will always dangle. It is worth mentioning, there is no indication that the "build-output" actions are limited to warnings. Doing some testing across multiple projects I only saw warning messages, but that certainly is not a comprehensive search. We could do a search of the Output string to see if "warning" appears there, but that seems brittle to me.
Given the above, I have updated the code to filter "build-output" messages by package when those messages appear in isolation. If there are other unconsumed events, we do not hide them.