IWF-693 return workflow run id when starting a workflow #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwolczynski
reviewed
Mar 27, 2025
iwf/unregistered_client.py
Outdated
Comment on lines
197
to
207
| workflow_start_response = unset_to_none( | ||
| handler_error_and_return( | ||
| post_api_v1_workflow_start.sync_detailed( | ||
| client=self.api_client, | ||
| json_body=request, | ||
| ) | ||
| ) | ||
| ) | ||
| return handler_error_and_return(response) | ||
|
|
||
| assert isinstance(workflow_start_response, WorkflowStartResponse) | ||
| return workflow_start_response.workflow_run_id |
Contributor
There was a problem hiding this comment.
I don't think you need unset_to_none here. I don't see anything that could be unset?
Contributor
There was a problem hiding this comment.
Could this be:
workflow_start_response = handler_error_and_return(
post_api_v1_workflow_start.sync_detailed(
client=self.api_client,
json_body=request,
)
)
if workflow_start_response is not None and isinstance(workflow_start_response, WorkflowStartResponse):
return workflow_start_response.workflow_run_id
else:
# something went terribly wrong
lwolczynski
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.