fix: Buffer not using global in browser, closes #259#260
Merged
Conversation
Collaborator
|
Thanks. Is it possible to test the new code somehow? |
Collaborator
|
ping @kyranjamie |
Contributor
Author
|
I had a look, but wasn't figure out how to test this. There are no tests are in place at present. Also ran into issues coercing a mock |
Collaborator
|
Thank you. |
This was referenced Feb 23, 2021
Merged
fanatid
pushed a commit
that referenced
this pull request
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #259
Redeclaring Buffer prohibits using a globally-defined polyfill.