Update cpp.yml #223
Merged
Update cpp.yml #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Ubuntu LLVM toolchain from Clang 20 to Clang 21 in the CI workflow.
- Switches the apt repository from
llvm-toolchain-focal-20tollvm-toolchain-noblefor Clang 21 - Updates the compile commands to install and invoke
clang-21instead ofclang-20
Comments suppressed due to low confidence (2)
.github/workflows/cpp.yml:36
- The Ubuntu codename 'noble' may not be supported by apt.llvm.org for the Clang toolchain. Verify that this distribution exists on apt.llvm.org or use a valid codename (e.g., 'jammy' or 'mantic').
sudo add-apt-repository "deb http://apt.llvm.org/noble/ llvm-toolchain-noble main"
.github/workflows/cpp.yml:37
- [nitpick] Clang version '21' is hard-coded in multiple steps; consider defining the version as a single variable or workflow input to simplify future upgrades.
sudo apt-get install clang-21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.