Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: retry delay calculation check #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2022
Merged

fix: retry delay calculation check #364

merged 2 commits into from
Nov 15, 2022

Conversation

vlastahajek
Copy link
Contributor

Closes #362

Proposed Changes

Checking calculated numbers to avoid passing a negative number to the random generator.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format

@vlastahajek vlastahajek requested a review from bednar November 15, 2022 13:05
@vlastahajek vlastahajek changed the title Fix/retry attempts limit fix: retry delay calculation check Nov 15, 2022
bednar
bednar approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vlastahajek vlastahajek merged commit 5971a9a into influxdata:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bednar bednar bednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when influxdb server shutdown, client still send metric, the background goroutine "w.writeProc()" will crash at rand.Intn() after try 52 times
2 participants
@vlastahajek @bednar