Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

vlastahajek
Copy link
Contributor

Closes #371

Proposed Changes

Fixed wrongly generated checks de/serialization

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@vlastahajek vlastahajek requested a review from bednar August 7, 2024 13:19
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍. There is only small requirement to be ready for release next week:

CHANGELOG.md Outdated
@@ -1,3 +1,8 @@
## Unreleased
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to ensure it's the same as in other clients before next week's release ;)

Suggested change
## Unreleased
## 2.14.0 [unreleased]

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vlastahajek vlastahajek merged commit b3496ca into influxdata:master Aug 7, 2024
2 checks passed
@bednar bednar added this to the 2.14.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIClient().GetChecks return null checks
2 participants