-
Notifications
You must be signed in to change notification settings - Fork 523
Resultset #154
Conversation
+ if a serie is the result of a "system" query: it has no name attribute. + a serie can also have no associated tags.
1) cli.query() which now returns a ResultSet, which must be list()ed in order to obtain the list of series. 2) assertListEqual instead of assertDictEqual for a list result. TODO: but now we have to fix the results format.
Other solution is to return the ResultSet instance but then we must adapt all call sites.. To be decided..
show series show list retention
600aeb9
to
b9430f9
Compare
Not that I'm against that you merge your own PR , but for this one there could/should have been at least a big squash of the vast majority of the temporary/tests commits.. and some few others things too that I'd have liked to comment on the final result.. it's never too late, in resultset.py :
|
We both worked on the PR and I didn't want to remove your authorship. The good thing to do would have been to squash it all under one single commit :( But you're right. I still could have squashed commits in-between. I'll wait for ResultSet to be stable before I make a new release, so its best to work on master. |
for such temporary crappy test commits it's ok ;)
ultimately yep. |
No description provided.